// Good - clear and well-structured
soul authenticateUser(username, password) {
if (username == null || username == "") {
return { success: false, message: "Username required" }
}
if (password == null || password == "") {
return { success: false, message: "Password required" }
}
user = findUserByUsername(username)
if (user == null) {
return { success: false, message: "User not found" }
}
if (!user.isActive) {
return { success: false, message: "Account disabled" }
}
if (user.password != password) {
return { success: false, message: "Invalid password" }
}
return { success: true, user: user }
}
// Better - with extracted validation functions
soul authenticateUser(username, password) {
validationResult = validateCredentials(username, password)
if (!validationResult.isValid) {
return validationResult
}
user = findUserByUsername(username)
userValidationResult = validateUser(user, password)
return userValidationResult
}